Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production-ready session #70

Closed
gsproston-scottlogic opened this issue Jul 26, 2023 · 3 comments · Fixed by #83
Closed

Production-ready session #70

gsproston-scottlogic opened this issue Jul 26, 2023 · 3 comments · Fixed by #83
Assignees
@gsproston-scottlogic
Labels
backend Requires work on the backend bug Something isn't working

Comments

@gsproston-scottlogic
Copy link
Contributor

Update the usage of the express session in the backend to be ready for production. Some notes:
@gsproston-scottlogic gsproston-scottlogic added bug Something isn't working backend Requires work on the backend labels Jul 26, 2023
@gsproston-scottlogic gsproston-scottlogic self-assigned this Jul 28, 2023
@gsproston-scottlogic
Copy link
Contributor Author

If using connect-redis for storage, this requires resave to be false and recommends saveUnitialized to be false.

@gsproston-scottlogic
Copy link
Contributor Author

Session name and secure cookies have been set. Will need dev ops help with setting up session storage such as Redis. So parking this for now.

@gsproston-scottlogic gsproston-scottlogic removed their assignment Jul 31, 2023
@gsproston-scottlogic
Copy link
Contributor Author

Made a new issue just for session storage #82 , making a PR of the work done here.

@gsproston-scottlogic gsproston-scottlogic linked a pull request Jul 31, 2023 that will close this issue
Session name and secure cookies #83
Merged
@gsproston-scottlogic gsproston-scottlogic self-assigned this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsproston-scottlogic gsproston-scottlogic

Labels
backend Requires work on the backend bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Session name and secure cookies ScottLogic/prompt-injection
1 participant
@gsproston-scottlogic