forked from netty/netty
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SslHandler promise completion incorrect if write doesn't immediately
complete Motivation: SslHandler removes a Buffer/Promise pair from AbstractCoalescingBufferQueue when wrapping data. However it is possible the SSLEngine will not consume the entire buffer. In this case SslHandler adds the Buffer back to the queue, but doesn't add the Promise back to the queue. This may result in the promise completing immediately in finishFlush, and generally not correlating to the completion of writing the corresponding Buffer Modifications: - AbstractCoalescingBufferQueue#addFirst should also support adding the ChannelPromise - In the event of a handshake timeout we should immediately fail pending writes immediately to get a more accurate exception Result: Fixes netty#7378.
- Loading branch information
1 parent
8618a33
commit ae58af8
Showing
3 changed files
with
36 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters