Channel promise of a write is successful, although SSL handshake fails. #7378
Comments
Scottmitch
added a commit
to Scottmitch/netty
that referenced
this issue
Nov 7, 2017
complete Motivation: SslHandler removes a Buffer/Promise pair from AbstractCoalescingBufferQueue when wrapping data. However it is possible the SSLEngine will not consume the entire buffer. In this case SslHandler adds the Buffer back to the queue, but doesn't add the Promise back to the queue. This may result in the promise completing immediately in finishFlush, and generally not correlating to the completion of writing the corresponding Buffer Modifications: - AbstractCoalescingBufferQueue#addFirst should also support adding the ChannelPromise - In the event of a handshake timeout we should immediately fail pending writes immediately to get a more accurate exception Result: Fixes netty#7378.
|
See #7380 |
andsel
pushed a commit
to andsel/netty
that referenced
this issue
Nov 15, 2017
complete Motivation: SslHandler removes a Buffer/Promise pair from AbstractCoalescingBufferQueue when wrapping data. However it is possible the SSLEngine will not consume the entire buffer. In this case SslHandler adds the Buffer back to the queue, but doesn't add the Promise back to the queue. This may result in the promise completing immediately in finishFlush, and generally not correlating to the completion of writing the corresponding Buffer Modifications: - AbstractCoalescingBufferQueue#addFirst should also support adding the ChannelPromise - In the event of a handshake timeout we should immediately fail pending writes immediately to get a more accurate exception Result: Fixes netty#7378.
kiril-me
pushed a commit
to kiril-me/netty
that referenced
this issue
Feb 28, 2018
complete Motivation: SslHandler removes a Buffer/Promise pair from AbstractCoalescingBufferQueue when wrapping data. However it is possible the SSLEngine will not consume the entire buffer. In this case SslHandler adds the Buffer back to the queue, but doesn't add the Promise back to the queue. This may result in the promise completing immediately in finishFlush, and generally not correlating to the completion of writing the corresponding Buffer Modifications: - AbstractCoalescingBufferQueue#addFirst should also support adding the ChannelPromise - In the event of a handshake timeout we should immediately fail pending writes immediately to get a more accurate exception Result: Fixes netty#7378.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
When a SSL handshake fails, a channel promise of a write operation should fail aswell.
Actual behavior
The channel promise succeeds.
Steps to reproduce
Minimal yet complete reproducer code (or URL to code)
https://github.com/s-gheldd/netty-reproducer
Netty version
4.1.16.Final(last version that had the expected behavior
4.1.13.Final)JVM version (e.g.
java -version)OS version (e.g.
uname -a)The text was updated successfully, but these errors were encountered: