-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More options for userscript matches (not only URLs) #23
Comments
I believe it's too late to implement this. It's not a big deal, either. Closing |
|
I believe this one is worth reopening. Once we implement #390, addons that work on the editor/project page would also need to work on turbowarp's editor/project page. If we simply said for the match URL to be |
And phosphorous
|
I honestly doubt userscript made for the Scratch editor could work "as-is" on TurboWarp, so it wouldn't make sense to merge both origins into one permission - an addon might only work on the Scratch editor |
Well maybe userstyles
Paul Reid
…________________________________
From: World_Languages <notifications@github.com>
Sent: Friday, January 1, 2021 3:15:04 PM
To: ScratchAddons/ScratchAddons <ScratchAddons@noreply.github.com>
Cc: Paul Reid <paul@reid-family.org>; Comment <comment@noreply.github.com>
Subject: Re: [ScratchAddons/ScratchAddons] More options for userscript matches (not only URLs) (#23)
I believe this one is worth reopening. Once we implement #390<#390>, addons that work on the editor/project page would also need to work on turbowarp's editor/project page. If we simply said for the match URL to be project, then we could have the match URL patterns for both turbowarp and scratch to link to htpps://scratch.mit.edu/projects/* and https://turbowarp.org/* (excluding the https://turbowarp.org/privacy.html page). And, if we end up supporting addons on another site, then it would be useful there too. This would also help with #646<#646>. And I think it's just easier if all the user needed to add in their addon, was just search or user
I honestly doubt userscript made for the Scratch editor could work "as-is" on TurboWarp, so it wouldn't make sense to merge both origins into one permission - an addon might only work on the Scratch editor
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOT5DESCRGJABLPA6US4W6TSXY3NRANCNFSM4PL5ILKA>.
|
I'm sure that most do, and some (like project-notes-tabs) could easily be fixed by adding an if statement to not run at all. |
How bout now hehe. But even so, this should 100% be implemented... for future mods. |
wl has recondered. pr soon. |
In this case, the addon can manually add the tag.
I argue that infinite scrolling and other addons like that should have the forums tag, even if their effect on it is very little. Alternatively, we can check if the userscripts/userstyles have the
The editor is not different pages, whereas the forums and the profiles are. |
This would cause similar issues as the theme tag did. I don't think we should add more features that affect both functionality and categorization like that. The forums tag should be only for addons users want to see when choosing "forums" in a menu. Maybe infinite scrolling should be one of them, but what about website dark mode? |
It still doesn't make sense for editor addons to behave differently than website addons in any way. |
Pull in minify workflow
Let's say a userscript only works on user profiles. The current match would currently be
https://scratch.mit.edu/users/*/
, why not justuserprofile
? And other potential filters for common use.The text was updated successfully, but these errors were encountered: