Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor addons work on TurboWarp #390

Closed
WorldLanguages opened this issue Oct 3, 2020 · 11 comments
Closed

Make editor addons work on TurboWarp #390

WorldLanguages opened this issue Oct 3, 2020 · 11 comments
Labels
scope: core Related to the core script/extension workings source: feedback From the feedback page (https://scratchaddons.com/feedback) or the Discord server type: enhancement New feature for the project

Comments

@WorldLanguages
Copy link
Member

This has been suggested twice today.
We do not have host permissions to TurboWarp, however, we can make use of optional permissions.
@GarboMuffin, do you have anything to say? To be honest, I was going to ask if it was somehow possibly to make an addon that simply replaced the editor with TurboWarp (not just the player - that's easy with an iframe - I mean moving the whole editor experience), but it feels basically impossible and complicated.

@WorldLanguages WorldLanguages added type: enhancement New feature for the project source: feedback From the feedback page (https://scratchaddons.com/feedback) or the Discord server labels Oct 3, 2020
@GarboMuffin
Copy link
Member

Replacing the project player is probably not feasible, especially given the ever increasing scope of the project.

As long as you don't claim to be officially endorsed by the TurboWarp project, I don't mind addons running on turbowarp.org.

@Hans5958 Hans5958 changed the title User feedback: make editor addons work on TurboWrap Make editor addons work on TurboWrap Oct 5, 2020
@WorldLanguages WorldLanguages added this to the Planned milestone Oct 17, 2020
@ghost
Copy link

ghost commented Nov 18, 2020

The issue title is misspelled

@retronbv
Copy link
Contributor

I have an idea.

add another section in
image
that says "Allow addons to run on TurboWarp" which will ask for permission to access turbowarp.org. thhen boom

@WorldLanguages WorldLanguages changed the title Make editor addons work on TurboWrap Make editor addons work on TurboWarp Nov 18, 2020
@WorldLanguages
Copy link
Member Author

@YOYITsM3M8 Yeah that's what I had in mind

@TheColaber
Copy link
Member

Would it actually be possible to run addons on turbowarp with optional permissions?

As far as I know, scripts can only run on certain websites, if the websites are declared in the content scripts section of the manifest file.

So wouldn't we need to have one of the matches be turbowarp here?

"content_scripts": [
{
"matches": ["https://scratch.mit.edu/*"],
"run_at": "document_start",
"js": ["content-scripts/cs.js"]
},
{
"matches": ["https://scratch.mit.edu/*"],
"run_at": "document_start",
"js": ["content-scripts/prototype-handler.js", "content-scripts/load-redux.js", "content-scripts/fix-console.js"]
}
],

@WorldLanguages
Copy link
Member Author

@TheColaber Yeah, it's not that complex. However please let me PR this myself

@TheColaber
Copy link
Member

@TheColaber Yeah, it's not that complex. However please let me PR this myself

I wasn't going to make this, I was asking if it was possiable.

@WorldLanguages
Copy link
Member Author

Moving to backlog for the possibility of TurboWarp including most (if not all) editor addons natively.

@RedGuy12
Copy link
Contributor

RedGuy12 commented Jan 3, 2021 via email

@Hans5958 Hans5958 added status: needs triage Needs triaging by putting relevant labels scope: core Related to the core script/extension workings and removed status: needs triage Needs triaging by putting relevant labels labels Jan 15, 2021
@WorldLanguages WorldLanguages removed this from the Backlog milestone Jan 18, 2021
@WorldLanguages
Copy link
Member Author

Closing this. TurboWarp should include our addons, not the other way around. This way, people don't need an extension to use our editor addons, shortening the discovery gap :)

@WorldLanguages
Copy link
Member Author

Turbowarp now has addons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core Related to the core script/extension workings source: feedback From the feedback page (https://scratchaddons.com/feedback) or the Discord server type: enhancement New feature for the project
Projects
None yet
Development

No branches or pull requests

6 participants