Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1.33.2 update notification #6256

Merged
merged 3 commits into from Jun 24, 2023
Merged

Add v1.33.2 update notification #6256

merged 3 commits into from Jun 24, 2023

Conversation

WorldLanguages
Copy link
Member

Resolves #6119

This update will ship after Scratch deploys the colors update.

brave_r8zy6KvHQp

@WorldLanguages WorldLanguages self-assigned this Jun 22, 2023
@WorldLanguages
Copy link
Member Author

@DNin01 I tweaked your suggestion a bit

@WorldLanguages WorldLanguages mentioned this pull request Jun 22, 2023
Closed
@WorldLanguages
Copy link
Member Author

Accidentally committed to the wrong branch. Ignore the previous 2 commits.

DNin01
DNin01 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@DNin01 DNin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the notification wording. Not tested.

@DNin01 DNin01 added status: needs review [Use when there's already 1 approval] Review needed on the PR scope: meta Related to the meta of the development (repository, store, etc) scope: core Related to the core script/extension workings labels Jun 22, 2023
@Samq64 Samq64 removed the status: needs review [Use when there's already 1 approval] Review needed on the PR label Jun 24, 2023
@WorldLanguages WorldLanguages merged commit 1ee7cb1 into ScratchAddons:master Jun 24, 2023
2 checks passed
@WorldLanguages
Copy link
Member Author

Sent this update notification (and a few more strings) to translators.

@WorldLanguages WorldLanguages mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samq64 Samq64 Samq64 approved these changes

@DNin01 DNin01 DNin01 approved these changes

@apple502j apple502j Awaiting requested review from apple502j apple502j is a code owner

Assignees

@WorldLanguages WorldLanguages

Labels
scope: core Related to the core script/extension workings scope: meta Related to the meta of the development (repository, store, etc)
Projects
None yet
Milestone
Scratch color changes (v1.33.2)
Development

Successfully merging this pull request may close these issues.

Let people know that there might be some issues after the Scratch color changes
3 participants
@WorldLanguages @Samq64 @DNin01