Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend auto-follow-topics addon #7243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DNin01
Copy link
Member

@DNin01 DNin01 commented Mar 3, 2024

The "Follow topics after posting" addon is very cool. I think many forums these days notify participants of forum threads of new activity, but Scratch's doesn't - only automatically for topics you create. That's why I would recommend this addon. A lot of us would probably want to know when someone responds to a topic they're participating in, most of the time.

To Do

  • Figure out whether this addon should be in the "Recommended" group or not

@DNin01 DNin01 added the scope: addon Related to one or multiple addons label Mar 3, 2024
@Samq64
Copy link
Member

Samq64 commented Mar 3, 2024

I'm not sure if it's intentional but it doesn't look like any forum exclusive addons have the recommended tag right now.

@DNin01
Copy link
Member Author

DNin01 commented Mar 8, 2024

I'm not sure if it's intentional but it doesn't look like any forum exclusive addons have the recommended tag right now.

We should test if there's anything that doesn't work right in the settings page due to this change. I might have just made this addon disappear from the Forums group.

@ghost
Copy link

ghost commented Mar 8, 2024

We should test if there's anything that doesn't work right in the settings page due to this change. I might have just made this addon disappear from the Forums group.

Nope, just tried on LibreWolf:
reccomended

@DNin01
Copy link
Member Author

DNin01 commented Mar 8, 2024

We should test if there's anything that doesn't work right in the settings page due to this change. I might have just made this addon disappear from the Forums group.

Nope, just tried on LibreWolf:

reccomended

I meant the section in the list, not the category.

@ghost
Copy link

ghost commented Mar 8, 2024

I meant the section in the list, not the category.

Oh, my apologies then!

@DNin01
Copy link
Member Author

DNin01 commented Mar 9, 2024

It does not show up under Forums, but instead Recommended. I suspected this because the condition for putting addons there is inside an else-if condition.

But wait, we already have some forum addons that are recommended or featured and also don't appear under Forums. However, those are all addons that also work on other areas of Scratch.

@WorldLanguages @Hans5958 What should we do about this? Should we ever recommend or feature forum-exclusive addons? These addons are probably separated into their own group for a reason, so if we were to recommend anything and keep that separation, we could place them under Forums instead of Recommended if they only do anything on forum pages.

@WorldLanguages
Copy link
Member

It does not show up under Forums, but instead Recommended.

I think that's fine.

I suspected this because the condition for putting addons there is inside an else-if condition.

We could change the grouping logic so that it shows in both groups, if we want (recommended forum addons would be listed twice).

@DNin01
Copy link
Member Author

DNin01 commented Mar 9, 2024

Another way to keep the separation but solve the problem of having forum addons not shown under the Forums group would be to place forum addons under other addons in the list, kind of like how we place website addons under editor addons, and then move everything under the Forums group into other groups.

Copy link
Member

@WorldLanguages WorldLanguages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should merge this, and consider changing the grouping algorithm later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: addon Related to one or multiple addons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants