Porter 4.0 release candidate #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed AbstractResource.
Added Porter constructor that receives a container of providers. Removed provider tags.
Changed Provider interface to require getConnector method instead of fetch.
…urability issues in Porter v3. Added SuperConnector to supervise delivery of ConnectionContext to connectors and validate cache availability.
Removed CacheAdvice (simplified to boolean). Removed obsolete Cache interface. Renamed SuperConnector -> ImportConnector and added class comment.
Removed dependency on eloquent/enumeration.
Added test for ImportSpecification::disableCache() to complete code coverage.
Bilge
commented
Oct 25, 2017
src/Connector/Connector.php
Outdated
| @@ -12,10 +12,11 @@ | |||
| * Fetches data from the specified source optionally augmented by the | |||
| * specified options. | |||
| * | |||
| * @param ConnectionContext $context TODO. | |||
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 28 29 +1
Lines 423 355 -68
=====================================
- Hits 423 355 -68
Continue to review full report at Codecov.
|
Removed ProviderOptions. Added ConnectorOptions interface and accompanying trait. Forced ConnectorOptions to implement __clone in Porter. These changes stop passing EncapsulatedOptions around in method calls, instead tieing them to their Connector implementation. This makes sense because connectors have a 1:1 relationship with their options. That is, different options cannot be used with different connectors. To make connectors and their options immutable during import, connectors are now cloned in Porter::fetch() and connectors exporting options must implement __clone() to deep clone their options.
…nfigure connector.
Added Stateless- and ExponentialSleep FetchExceptionHandler implementations. Changed FEH defacto type from callable to FetchExceptionHandler.
Changed "provider" FEH name to "resource" fetch exception handler. Changed resource FEH type from callable to FetchExceptionHandler.
…onContext. Fixed type hints in ImportConnector from callable -> FetchExceptionHandler.
…nstead of silently converting invalid values.
benefit from its performance optimizations.
Added missing CachingConnector::__clone() method. Added ImportConnector::findBaseConnector(). Changed CachingConnector to implement ConnectorWrapper. Changed ImportConnector to clone its connector instead of relying on caller. Fixed some ImportSpecification docblocks.
Added test for CachingConnector::__clone().
Added accompanying RecordCollectionTest::testNonArrayYield test.
This was referenced Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Compile change log.
Closes #35, #38, #39, #41, #42, #44 through inclusion.