Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added connection context as first parameter to all connectors #42

Closed
wants to merge 4 commits into from

Conversation

Bilge
Copy link
Member

@Bilge Bilge commented Jul 16, 2017

Connection context provides runtime information about the current import via utility functions. Specifically, a preset connection retry method and cache advice methods.

…urability issues in Porter v3.

Added SuperConnector to supervise delivery of ConnectionContext to connectors and validate cache availability.
@codecov-io
Copy link

codecov-io commented Jul 16, 2017

Codecov Report

❗ No coverage uploaded for pull request base (remove-abstract-provider@02a8131). Click here to learn what that means.
The diff coverage is 98.3%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             remove-abstract-provider      #42   +/-   ##
===========================================================
  Coverage                            ?   99.74%           
===========================================================
  Files                               ?       29           
  Lines                               ?      391           
  Branches                            ?        0           
===========================================================
  Hits                                ?      390           
  Misses                              ?        1           
  Partials                            ?        0
Impacted Files Coverage Δ
src/Connector/ConnectionContextFactory.php 100% <100%> (ø)
src/Connector/CachingConnector.php 100% <100%> (ø)
src/Porter.php 100% <100%> (ø)
src/Connector/NullConnector.php 100% <100%> (ø)
src/Cache/CacheUnavailableException.php 100% <100%> (ø)
src/Provider/Resource/StaticResource.php 100% <100%> (ø)
src/Connector/ConnectionContext.php 100% <100%> (ø)
src/Connector/SuperConnector.php 93.33% <93.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a8131...5800e70. Read the comment docs.

@Bilge Bilge added this to the 4.0.0 milestone Jul 16, 2017
@Bilge Bilge force-pushed the connection-context branch 2 times, most recently from c1a20a8 to fff6456 Compare July 16, 2017 16:31
@Bilge
Copy link
Member Author

Bilge commented Apr 9, 2018

Included in #46.

@Bilge Bilge closed this Apr 9, 2018
@Bilge Bilge deleted the connection-context branch April 9, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants