Skip to content
This repository has been archived by the owner on May 12, 2024. It is now read-only.

Data structures improvements #11

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Data structures improvements #11

merged 2 commits into from
Jun 26, 2022

Conversation

Samyak2
Copy link
Collaborator

@Samyak2 Samyak2 commented Jun 23, 2022

PR Info

  • Closes
  • Dependencies:
  • Dependents:

Changes

  • Use a single Null variant instead of a Null variant of each type
  • Moved Value into its own module
  • Better Column struct - the name was repeated inside ColumnDef and collate did not seem useful at this point
  • Documented all public structs, enums and methods
  • Added more tests
  • Change Register::Table to Register::View

@Samyak2 Samyak2 mentioned this pull request Jun 25, 2022
Merged
@tyt2y3 tyt2y3 merged commit 539036d into main Jun 26, 2022
@Samyak2 Samyak2 mentioned this pull request Jun 26, 2022
Open
4 tasks
@Samyak2 Samyak2 deleted the data-structures-2 branch July 10, 2022 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Samyak2 @tyt2y3