-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all unwrap()
with expect()
#1023
Comments
I wish to take this into account by the way, necessary for error distinguish :#881 |
Can we have a new label named "Motivation" with prefixes like beginner, moderate and expert ....... Would help to filter the issues |
Oh Nice I wanted to say this a long time ago. But it's also good to think about whether we can avoid panicking on a case by case basis. |
+1 |
Same here. Btw, we should document all the method that throw panic, specify under what circumstance it will panic. Deny this linter and it will tell you which methods need to be documented Also, this linter would be helpful to deny the use of |
I'm going to do a cleanup on the open issues and label some beginner friendly issues as "good first issue". And convert Q&A into discussion. |
I agree. @billy1624 |
Motivation
We should refactor all
unwrap()
in SeaORM and useexpect()
insead. This will force us to provide a explicit message when panicking. This is far more readable than a muted panic.The text was updated successfully, but these errors were encountered: