Cleanup panic and unwrap

[billy1624]

PR Info

• Closes Replace all unwrap() with expect() #1023

Changes

• Implemented From<DbErr> for TransactionError<E>

[billy1624]

Please review!

[tyt2y3]

Looks good for what this PR changes

[tyt2y3]

This PR mostly touches the Connection and Mock API, I think there might be other places to cleanup too?

[billy1624]

This PR mostly touches the Connection and Mock API, I think there might be other places to cleanup too?

Hey @tyt2y3, yes, but I think we can leave them as-is:

20 results - 10 files

src/entity/active_model.rs:
  168              }
  169:             _ => panic!("The arity cannot be larger than 6"),
  170          }

  812              ActiveValue::Set(value) | ActiveValue::Unchanged(value) => value,
  813:             ActiveValue::NotSet => panic!("Cannot unwrap ActiveValue::NotSet"),
  814          }

  844              ActiveValue::Set(value) | ActiveValue::Unchanged(value) => value,
  845:             ActiveValue::NotSet => panic!("Cannot borrow ActiveValue::NotSet"),
  846          }

src/entity/base_entity.rs:
  270              } else {
  271:                 panic!("primary key arity mismatch");
  272              }

  274          if keys.next().is_some() {
  275:             panic!("primary key arity mismatch");
  276          }

  837              } else {
  838:                 panic!("primary key arity mismatch");
  839              }

  841          if keys.next().is_some() {
  842:             panic!("primary key arity mismatch");
  843          }

src/executor/cursor.rs:
  95                  .add(f(c1, v1)),
  96:             _ => panic!("column arity mismatch"),
  97          }

src/executor/execute.rs:
  48              ExecResultHolder::SqlxPostgres(_) => {
  49:                 panic!("Should not retrieve last_insert_id this way")
  50              }

  54                  if last_insert_rowid < 0 {
  55:                     panic!("negative last_insert_rowid")
  56                  } else {

src/query/combine.rs:
  49                              ColumnRef::Asterisk | ColumnRef::TableAsterisk(_) => {
  50:                                 panic!("cannot apply alias for Column with asterisk")
  51                              }

  58                                  ColumnRef::Asterisk | ColumnRef::TableAsterisk(_) => {
  59:                                     panic!("cannot apply alias for AsEnum with asterisk")
  60                                  }

  62                              _ => {
  63:                                 panic!("cannot apply alias for AsEnum with expr other than Column")
  64                              }
  65                          },
  66:                         _ => panic!("cannot apply alias for expr other than Column or AsEnum"),
  67                      };

src/query/delete.rs:
  115                  }
  116:                 ActiveValue::NotSet => panic!("PrimaryKey is not set"),
  117              }

src/query/helper.rs:
  585          }
  586:         _ => panic!("Owner key and foreign key mismatch"),
  587      }

src/query/insert.rs:
  136              } else if self.columns[idx] != av_has_val {
  137:                 panic!("columns mismatch");
  138              }

src/query/update.rs:
   99                  }
  100:                 ActiveValue::NotSet => panic!("PrimaryKey is not set"),
  101              }

src/schema/entity.rs:
  49      if matches!(backend, DbBackend::MySql | DbBackend::Sqlite) {
  50:         panic!("TypeCreateStatement is not supported in MySQL & SQLite");
  51      }

  59          ColumnType::Enum { name, variants } => (name.clone(), variants.clone()),
  60:         _ => panic!("Should be ColumnType::Enum"),
  61      };

[billy1624]

There are too many breaking changes stapled together, which is risky. Can we avoid all breaking changes, if possible?

Sure! Check again :D

[tyt2y3]

This is still a LOT of changes and hopefully I did not miss a fine detail

[tyt2y3]

👍