Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Vector of enum for Postgres #1210

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Support Vector of enum for Postgres #1210

merged 7 commits into from
Nov 15, 2022

Conversation

billy1624
Copy link
Member

PR Info

New Features

  • Support Vector of Enum

Breaking Changes

  • Add ActiveEnum::ValueVec associated type

Changes

  • Add postgres-array feature to sea-orm-macros

@billy1624 billy1624 self-assigned this Nov 8, 2022
This was referenced Nov 8, 2022
Closed
Merged
@billy1624 billy1624 marked this pull request as ready for review November 8, 2022 08:14
@billy1624 billy1624 requested a review from tyt2y3 November 8, 2022 08:15
@tyt2y3
Copy link
Member

tyt2y3 commented Nov 10, 2022 •
edited
Loading

What about integer-backed enum, is it going to work? Can we add a test case for it?

@billy1624
Copy link
Member Author

billy1624 commented Nov 11, 2022 •
edited
Loading

The test was success we still need to bump SeaQuery and SeaSchema's SeaQuery to make sea-orm-migration works.
https://github.com/SeaQL/sea-orm/actions/runs/3444608221/jobs/5747485506#step:6:46

@tyt2y3 tyt2y3 merged commit 4d8645a into master Nov 15, 2022
@tyt2y3 tyt2y3 deleted the pg-enum-array branch November 15, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to use Vec<Enum> in database
2 participants
@billy1624 @tyt2y3