SelectTwo cursor by, cursorTrait revamp #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
reviewed
Aug 24, 2023
tests/upsert_tests.rs
Outdated
There was a problem hiding this comment.
This is a very interesting test case. But 1) please add, not change and 2) this is not relevant to the current PR?
tyt2y3
reviewed
Aug 24, 2023
Comment on lines
+411
to
+412
| #[smol_potat::test] | ||
| async fn first_2_before_10_also_related_select() -> Result<(), DbErr> { |
There was a problem hiding this comment.
These tests are cool! Would appreciate a few integration tests (in sqlite/mysql/postgres)
tyt2y3
reviewed
Aug 25, 2023
…and primary key from other table
tyt2y3
reviewed
Sep 22, 2023
| } | ||
|
|
||
| impl<S> Cursor<S> | ||
| where | ||
| S: SelectorTrait, | ||
| { | ||
| /// Initialize a cursor | ||
| pub fn new<C>(query: SelectStatement, table: DynIden, order_columns: C) -> Self | ||
| pub fn new<C>( |
tyt2y3
approved these changes
Sep 22, 2023
|
This has also been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
CursorTraitforSelectTwo#1805New Features
Bug Fixes
Breaking Changes
Changes
CursorTraitbehaviour, can be phased out in future