Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --enum-extra-derives #1934

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Support --enum-extra-derives #1934

merged 4 commits into from
Nov 8, 2023

Conversation

TmLev
Copy link
Contributor

@TmLev TmLev commented Oct 24, 2023

PR Info

Doesn't close any issues (or I didn't find them).

Supersedes #1392.

New Features

  • New --enum-extra-derives CLI option allows for adding custom derives to active enums.

Bug Fixes

None.

Breaking Changes

Fully backward compatible for the end user.

Changes

Made bonus_derives pub(crate) to use its functionality in the test.

@TmLev
Copy link
Contributor Author

TmLev commented Nov 3, 2023

Hey @tyt2y3, @billy1624, could you please spare five minutes to review this and #1952 PRs when you get a chance? Thanks!

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Will merge after CI passes

@TmLev
Copy link
Contributor Author

TmLev commented Nov 8, 2023

Oh, right, #[rustfmt::skip]. I'll fix that in a jiffy.

@TmLev
Copy link
Contributor Author

TmLev commented Nov 8, 2023

Done!

@tyt2y3 tyt2y3 merged commit 0dbfb42 into SeaQL:master Nov 8, 2023
25 checks passed
Copy link

🎉 Released In 0.12.5 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants