Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated active enum use statements on generated entities #1953

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

onefifth
Copy link
Contributor

@onefifth onefifth commented Nov 2, 2023

PR Info

Merges original fix by @lukasschlueter and adds tests for gen_import_active_enum

Bug Fixes

  • Fixes generated entities containing multiple identically typed ColumnType::Enum columns from having duplicated import statements.

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good. Should be good to merge after CI passes.

@tyt2y3 tyt2y3 requested a review from billy1624 November 8, 2023 17:06
@tyt2y3 tyt2y3 merged commit 5fe81c5 into SeaQL:master Nov 8, 2023
31 of 32 checks passed
@tyt2y3
Copy link
Member

tyt2y3 commented Nov 8, 2023

CC @billy1624 there is more test code than actual impl, so should be good

Copy link

🎉 Released In 0.12.5 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sea-orm-codegen: Enum use statements getting generated multiple times
3 participants