Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rocket #1959

Merged
merged 1 commit into from Nov 6, 2023
Merged

Update Rocket #1959

merged 1 commit into from Nov 6, 2023

Conversation

wyatt-herkamp
Copy link
Contributor

PR Info

Updates Rocket to 0.5.0-rc.4. The OkAPI has not updated so that example is currently broken.

Bug Fixes

Breaking Changes

  • Rocket 0.5.0-rc.4 is required

@wyatt-herkamp wyatt-herkamp marked this pull request as ready for review November 3, 2023 14:52
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I will merge and release tmr

@tyt2y3 tyt2y3 merged commit 8b8b2ae into SeaQL:master Nov 6, 2023
31 of 32 checks passed
@wyatt-herkamp wyatt-herkamp deleted the rocket branch November 6, 2023 11:40
@tyt2y3
Copy link
Member

tyt2y3 commented Jan 21, 2024

@wyatt-herkamp have you updated to Rocket 0.5 (non rc yet)?

https://github.com/SeaQL/sea-orm/actions/runs/7602400927/job/20702921249 This seems to be working

@wyatt-herkamp
Copy link
Contributor Author

I have never used Rocket. I only made the PR to fix the compile error on another pr.

@wyatt-herkamp
Copy link
Contributor Author

I can make a pr to update sea_orm if you want me to?

@tyt2y3
Copy link
Member

tyt2y3 commented Jan 21, 2024

I bumped on master (c2e6e54) already, and would like to have some confirmation as to whether 0.5.0-rc.4 is compatible with 0.5.0. I assume it is. Since you are not using Rocket, then no worries. Thank you all in all!

@m4tx m4tx mentioned this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants