Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source annotations to errors #1999

Merged
merged 1 commit into from Dec 8, 2023
Merged

Add source annotations to errors #1999

merged 1 commit into from Dec 8, 2023

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Dec 8, 2023

New Features

  • Add #[source] annotation to DbError and RuntimeErr to expose underlying errors

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 8, 2023

Thanks. Can you share a bit what you need it for?

@bouk
Copy link
Contributor Author

bouk commented Dec 8, 2023

See the thiserror docs, this makes it so the Error.source method exposes the underlying error.

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 8, 2023

Thanks

@tyt2y3 tyt2y3 merged commit a1396f3 into SeaQL:master Dec 8, 2023
31 checks passed
Copy link

github-actions bot commented Dec 8, 2023

🎉 Released In 0.12.9 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants