Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast enums in is_in and is_not_in (#1527) #2002

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Cast enums in is_in and is_not_in (#1527) #2002

merged 2 commits into from
Dec 14, 2023

Conversation

Expurple
Copy link
Contributor

@Expurple Expurple commented Dec 9, 2023

Fixes #1527

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 10, 2023 •
edited
Loading

Thank you for the contribution!

Two things: can you add new test cases and keep the existing ones unchanged? More coverage is better.
May be also add some assertions against the generated SQL ?

@Expurple
Copy link
Contributor Author

Sure. Have another look now

tyt2y3
tyt2y3 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tyt2y3 tyt2y3 merged commit 1abc47b into SeaQL:master Dec 14, 2023
30 of 31 checks passed
@github-actions GitHub Actions
Copy link

🎉 Released In 0.12.10 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is_in and is_not_in don't use CAST when comparing enums.
2 participants
@Expurple @tyt2y3