Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_table_from_entity support comment #2009

Merged
merged 6 commits into from Dec 14, 2023
Merged

create_table_from_entity support comment #2009

merged 6 commits into from Dec 14, 2023

Conversation

Caisin
Copy link
Contributor

@Caisin Caisin commented Dec 13, 2023

PR Info

  • Closes
  • Dependencies:
  • Dependents:

New Features

  • create_table_from_entity support comment

Bug Fixes

Breaking Changes

Changes

@tyt2y3
Copy link
Member

tyt2y3 commented Dec 13, 2023

Oh wow thank you for the contribution!

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change one of the test cases under https://github.com/SeaQL/sea-orm/tree/master/tests/common/features to add the comment attribute and assert against the generated SeaQuery statement ?

You can find the assertions here https://github.com/SeaQL/sea-orm/blob/master/tests/common/features/schema.rs

@Caisin
Copy link
Contributor Author

Caisin commented Dec 14, 2023

@tyt2y3 done pls check

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Will merge after everything passes

@tyt2y3 tyt2y3 merged commit 94eac96 into SeaQL:master Dec 14, 2023
31 checks passed
Copy link

🎉 Released In 0.12.10 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants