fix: fully qualify types in DeriveValueType macro #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DeriveValueType` proc macro relies on several sea-orm types to be imported. This is partially fixed in SeaQL#1855 by fully qualifying `sea_orm::QueryResult`, but others like `sea_orm::Value` is still not being qualified. Also, if use defined a type alias on `std::result::Result`, it can cause the proc macro to generate code that won't compile. - Fully qualify `sea_orm::Value`, `std::string::String`, and `std::result::Result` in `DeriveValueType` proc macro. - Add some simple integration tests for this. - Add doc and doc test in `sea_orm_macro::derive_value_type`.
tyt2y3
approved these changes
Jan 12, 2024
🎉 Released In 0.12.11 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeriveValueTypeproc macro relies on several sea-orm types to be imported. This is partially fixed in #1855 by fully qualifyingsea_orm::QueryResult, but others likesea_orm::Valueis still not being qualified. Also, if use defined a type alias onstd::result::Result, it can cause the proc macro to generate code that won't compile.sea_orm::Value,std::string::String, andstd::result::ResultinDeriveValueTypeproc macro.sea_orm_macro::derive_value_type.PR Info
Bug Fixes
DeriveValueTypeproc macro relies on several sea-orm types to be imported.