-
-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream Changes - 4 #2168
Upstream Changes - 4 #2168
Conversation
@@ -171,7 +171,7 @@ pub async fn run_generate_command( | |||
.filter(|schema| filter_skip_tables(&schema.info.name)) | |||
.map(|schema| schema.write()) | |||
.collect(); | |||
(Some(schema.schema), table_stmts) | |||
(database_schema, table_stmts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should only pass through non-default schema here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
match schema_name { | ||
Some(schema_name) => { | ||
if schema_name != "public" { | ||
Some(quote! { #schema_name }) | ||
} else { | ||
None | ||
} | ||
} | ||
None => None, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we can remove this checking at codegen. This checking should be part of CLI anyway.
No description provided.