Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify case-transform using the same crate #264

Merged
merged 4 commits into from Oct 21, 2021
Merged

Unify case-transform using the same crate #264

merged 4 commits into from Oct 21, 2021

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 self-assigned this Oct 21, 2021
@billy1624 billy1624 marked this pull request as ready for review October 21, 2021 06:33
tyt2y3
tyt2y3 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

issues/262/src/main.rs

#[async_std::main]
pub async fn main() {
let db = Database::connect("mysql://sea:sea@localhost/bakery")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get away with a mock. It makes compilation much faster

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can

@billy1624 billy1624 force-pushed the fix-case-transform branch 4 times, most recently from 43e2a2d to 94a0311 Compare October 21, 2021 10:48
@tyt2y3 tyt2y3 merged commit e256034 into master Oct 21, 2021
@tyt2y3 tyt2y3 deleted the fix-case-transform branch October 21, 2021 11:20
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 21, 2021

Well, this is a far too magical DSL

@billy1624
Copy link
Member Author

Indeed :P

@renovate renovate bot mentioned this pull request Apr 25, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nappa85 nappa85 nappa85 left review comments

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different case-trasform systems used results in different naming
3 participants
@billy1624 @tyt2y3 @nappa85