Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing async_trait from non async trait in connection.rs #737

Merged
merged 1 commit into from
Jul 17, 2022
Merged

removing async_trait from non async trait in connection.rs #737

merged 1 commit into from
Jul 17, 2022

Conversation

sjud
Copy link
Contributor

@sjud sjud commented May 16, 2022 •
edited

removed 1 async trait macro over trait that is not async

billy1624
billy1624 approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @sjud Nice observation!

@billy1624 billy1624 requested a review from tyt2y3 July 15, 2022 09:20
@tyt2y3
Copy link
Member

tyt2y3 commented Jul 17, 2022

Thank you

@tyt2y3 tyt2y3 merged commit 3d40960 into SeaQL:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@sjud sjud

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sjud @tyt2y3 @billy1624