Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports time along with with chrono #267

Merged
merged 9 commits into from
Mar 15, 2022
Merged

Supports time along with with chrono #267

merged 9 commits into from
Mar 15, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Mar 12, 2022 •
edited

PR Info

Adds

  • Add time crate related features: with-time, postgres-time
  • Add time variants to Value
  • Supports binding of time Value in all drivers

Breaking Changes

  • Prefix the name of chrono Value variants with Chrono

@billy1624 billy1624 self-assigned this Mar 12, 2022
@billy1624 billy1624 changed the title Supports time alongside with chrono Supports time along with with chrono Mar 12, 2022
@billy1624 billy1624 mentioned this pull request Mar 13, 2022
Merged
@billy1624 billy1624 marked this pull request as ready for review March 13, 2022 10:35
@billy1624 billy1624 requested a review from tyt2y3 March 13, 2022 10:35
@tyt2y3
Copy link
Member

tyt2y3 commented Mar 13, 2022 •
edited

awesome. would need at least one example that make use of this new type

This was referenced Mar 13, 2022
Closed
Closed
tyt2y3
tyt2y3 requested changes Mar 15, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example needed

@billy1624
Copy link
Member Author

Example needed

Added

tyt2y3
tyt2y3 approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@tyt2y3 tyt2y3 merged commit 1cadf7e into SeaQL:master Mar 15, 2022
@tyt2y3 tyt2y3 mentioned this pull request Oct 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billy1624 @tyt2y3