Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues-383 Remove thread-safe feature #431

Merged
merged 4 commits into from
Sep 4, 2022
Merged

issues-383 Remove thread-safe feature #431

merged 4 commits into from
Sep 4, 2022

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev commented Sep 3, 2022 •
edited
Loading

PR Info

Adds

  • remove thread-safe feature fro sea-query-rusqlite

@ikrivosheev ikrivosheev mentioned this pull request Sep 3, 2022
Merged
@ikrivosheev ikrivosheev mentioned this pull request Sep 3, 2022
Closed
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 4, 2022

Actually, why do we need this? Downstream can enable that feature flag (on their own) without going through binder

@ikrivosheev ikrivosheev changed the title issues-383 Add thread-safe feature issues-383 Remove thread-safe feature Sep 4, 2022
@ikrivosheev
Copy link
Member Author

@tyt2y3 yes! You are rigth, cargo create union for features. This PR remove thread-safe feature from sea-query-rusqlute

@tyt2y3 tyt2y3 merged commit ef6e47e into SeaQL:master Sep 4, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-383_thread-safe branch September 4, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate / remove driver in favour of binder
2 participants
@ikrivosheev @tyt2y3