issues-485 Fix syntax error

[ikrivosheev]

PR Info

• Closes Negating an empty condition results in a syntax error #485

Bug Fixes

• Fix syntax error when have empty Condition

[nitnelave]

Maybe we should add a test with the negation of an empty any/all?

[nitnelave]

I think there's some unfortunate interaction between 2 features here:

• Collapsing an empty any/all into a boolean
• Not adding an any/all that's empty.

This should be any(TRUE, FALSE), so TRUE

[tyt2y3]

This is reasonable

[tyt2y3]

Update: I am trying to understand why it outputs FALSE here:

I imagine the expected output to be:

SELECT `id` FROM `glyph` WHERE TRUE OR FALSE

[tyt2y3]

Ah found it

[tyt2y3]

Maybe we should add a test with the negation of an empty any/all?

Agreed.

Actually, I think we should remove the behaviour Not adding an any/all that's empty, this would make the reasoning much easier. It was added in the first place to tackle the same problem. If we got a more proper solution, there is no reason to keep that.

[nitnelave]

Just got bitten by this bug again, with an any(not(any()), not(any())) which evaluated to true instead of false.

[tyt2y3]

@nitnelave Can you go over this again and may be add some tests as you see fit?

[ikrivosheev]

@tyt2y3 I think, we can compress conditional when we add it.

[tyt2y3]

we can compress conditional when we add it.

I imagine TRUE OR FALSE rarely appears in real life, so might not worth the effort?

[nitnelave]

I'm of the opinion that the query builder should not try to be too smart, since that's the role of the DB. They'll have no problem with an extra "OR FALSE" in the query.

[ikrivosheev]

@nitnelave @tyt2y3 ok.