Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issues-344] Improve expr #528

Merged
merged 3 commits into from
Nov 28, 2022
Merged

[issues-344] Improve expr #528

merged 3 commits into from
Nov 28, 2022

Conversation

ikrivosheev
Copy link
Member

New Features

  • Added SimpleExpr::eq
  • Added SimpleExpr::ne
  • Added Expr::not_equals

Breaking Changes

  • Deprecated SimpleExpr::equals
  • Deprecated SimpleExpr::not_equals
  • Expr::equals not accept C: IntoColumntRef instead T: IntoIden, C: IntoIden

@ikrivosheev ikrivosheev self-assigned this Nov 25, 2022
tyt2y3
tyt2y3 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome this is making our API more consistent

@ikrivosheev ikrivosheev merged commit de0e904 into SeaQL:master Nov 28, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-344_improve_expr branch November 28, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

@billy1624 billy1624 Awaiting requested review from billy1624

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikrivosheev @tyt2y3