Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to configure the Table enum variant Iden implementation with enum_def macro #759

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

Gaelik-git
Copy link
Contributor

Hello !

Add possibility to configure the Table enum variant Iden implementation with enum_def macro

Do you think it would possible to merge the PR ?
Does the feature fit in what you are trying to do ?

@Gaelik-git Gaelik-git force-pushed the table_iden_option_on_enum_def branch from b96909e to 7e6b85f Compare March 10, 2024 19:30
@tyt2y3
Copy link
Member

tyt2y3 commented Apr 14, 2024

I changed table_iden to table_name

@Gaelik-git Gaelik-git deleted the table_iden_option_on_enum_def branch April 14, 2024 20:25
@tyt2y3
Copy link
Member

tyt2y3 commented Apr 14, 2024

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 14, 2024

As mentioned in another comment, I would like to deprecate sea-query-attr and move the macro into sea-query-derive. However, we'll have to migrate to syn2 and probably rename a few things. Would you like to do that?

Copy link

🎉 Released In 0.31.0-rc.5 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants