Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect discovery of composite foreign keys in PostgreSQL #118

Merged
merged 3 commits into from Jan 18, 2024
Merged

Fix incorrect discovery of composite foreign keys in PostgreSQL #118

merged 3 commits into from Jan 18, 2024

Conversation

julmaxi
Copy link
Contributor

@julmaxi julmaxi commented Jan 14, 2024

@tyt2y3
Copy link
Member

tyt2y3 commented Jan 14, 2024 •
edited

That's awesome. We wanted to fix this for a while, thanks for stepping in!

@billy1624 can you check this

@tyt2y3 tyt2y3 requested a review from billy1624 January 14, 2024 16:13
@tyt2y3
Copy link
Member

tyt2y3 commented Jan 17, 2024

Awesome, thank you all

tyt2y3
tyt2y3 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you everyone!

@tyt2y3 tyt2y3 merged commit fddcc02 into SeaQL:master Jan 18, 2024
26 of 27 checks passed
@github-actions GitHub Actions
Copy link

🎉 Released In 0.14.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@billy1624 billy1624 mentioned this pull request Jan 19, 2024
Merged
Closed
28Smiles added a commit to 28Smiles/sea-schema that referenced this pull request Apr 21, 2024
@28Smiles
Revert "Fix incorrect discovery of composite foreign keys in PostgreS…
9b5ddcc 
…QL (SeaQL#118)"

This reverts commit fddcc02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

@billy1624 billy1624 Awaiting requested review from billy1624

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@julmaxi @tyt2y3 @billy1624