Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R dependencies >= 3.3.0 #236

Closed
ben-schwen opened this issue Feb 22, 2022 · 2 comments
Closed

R dependencies >= 3.3.0 #236

ben-schwen opened this issue Feb 22, 2022 · 2 comments

Comments

@ben-schwen
Copy link

Hi,
I tried to install collapse on R 3.1.0 but compiling went wrong because of

error: ‘SHALLOW_DUPLICATE_ATTRIB’ was not declared in this scope; did you mean ‘DUPLICATE_ATTRIB’?

in multiple files. The reason is that SHALLOW_DUPLICATE_ATTRIB was introduced in 3.3.0

@SebKrantz
Copy link
Owner

Thanks a lot! I started using some different macros going to 1.7, but I wasn't aware that that decreased backwards compatibility. I would like to stick with SHALLOW_DUPLICATE_ATTRIB though as it is considerably more efficient than DUPLICATE_ATTRIB, particularly for data frames with grouping objects attached. Any particular reason you need to use R 3.1.0? PS: I'll have to submit a patch next week when fixest gets taken off CRAN, so I'll bump up the R dependency then.

@ben-schwen
Copy link
Author

Ofc, you can always backport those things, but things become messy when you have to backport a lot.

No particular reason for 3.1.0, I was just surprised to see that >= 2.10 should work and 3.1.0 was the oldest version, I already had installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants