Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Doesn't Remove Check-Marked Mission #33

Closed
EvilsSouls opened this issue May 2, 2022 · 12 comments
Closed

[Bug] Doesn't Remove Check-Marked Mission #33

EvilsSouls opened this issue May 2, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@EvilsSouls
Copy link
Contributor

After dropping a delivery off with a reasonable score it doesn't remove the check-marked mission.

bugged_geography_thing

I'm using Linux Mint.

@EvilsSouls EvilsSouls changed the title [Bug] Doesn't Remove [Bug] Doesn't Remove Check-Marked Mission May 2, 2022
@SebLague SebLague added bug Something isn't working help wanted Extra attention is needed labels May 2, 2022
@selwynorren
Copy link

Hmm Yup I had this happen once as well. I will try and see if I can replicate

@EvilsSouls
Copy link
Contributor Author

Hmm Yup I had this happen once as well. I will try and see if I can replicate

Yeah... For me it happens almost every time when I drop a delivery off. I first thought that it only happened when I had a reasonable score, but now it seems like just when I drop something off.

@SebLague
Copy link
Owner

SebLague commented May 2, 2022

If you're willing to open the project in the Unity editor and run it there, it'd be very helpful to know if it's throwing some sort of error when this issue occurs.

@a96lex
Copy link

a96lex commented May 2, 2022

Hi, I just noticed I created a duplicate here #37, I'll close it.
I noticed that this happened when i dropped a package on map view (#36)

@dis-da-moe
Copy link

dis-da-moe commented May 2, 2022

Hi, I just noticed I created a duplicate here #37, I'll close it. I noticed that this happened when I dropped a package on map view (#36)

I've been trying to replicate this issue, so thanks for saying that it happens when map view is open.

@SebLague Unity produces this error when the UI is meant to update:

Screenshot 2022-05-03 000133

I can do a PR that stops packages being dropped from the map view, it should solve this issue and issue #36

Edit: for more details, the issue is that in map view, the Targets game object (the parent of the TargetUI) is inactive, and so when a package is dropped, a new TargetUI for the next country is instantiated, but because its parent is set to the inactive Target game object, its Awake method isn't called where the RectTransform is set, and so its RectTransform is null, meaning an error occurs when the UI needs to be resized for the animation.

@SebLague
Copy link
Owner

SebLague commented May 2, 2022

Thanks for investigating! I've fixed the package/map bug in the latest commit (will update builds soon). Can anyone confirm if this issue can still arise without having first attempted to drop a package in map view?

@Sobgo
Copy link

Sobgo commented May 3, 2022

I'm still able to recreate this issue by opening map while swap animation is being played.
Old name doesn't disappear and new name gets stuck on screen edge (shorter names can be even completely off-screen)
unknown
then after next animation names will overlap
unknown2

@Sobgo
Copy link

Sobgo commented May 3, 2022

I don't know Unity specifics but one solution to this could be checking/repositioning all city names after closing a map.

@SebLague
Copy link
Owner

SebLague commented May 3, 2022

Thanks @Sobgo, I've been able to reproduce the issue now and will work on a fix.

@EvilsSouls
Copy link
Contributor Author

Thanks @Sobgo, I've been able to reproduce the issue now and will work on a fix.

I downloaded the newest version on itch and I again got the issue.
image

I as normal opened the map after I dropped the package off and it happend. Although this has been the first time again since like 1.5 hours. After the bug my mouse also appeared.

@SebLague
Copy link
Owner

SebLague commented May 3, 2022

Should finally be fixed (fingers crossed) in latest build (1.0.3).

@SebLague SebLague removed the help wanted Extra attention is needed label May 3, 2022
@EvilsSouls
Copy link
Contributor Author

EvilsSouls commented May 4, 2022

Should finally be fixed (fingers crossed) in latest build (1.0.3).

Oh ok! I'll try it out tomorrow.

@SebLague SebLague closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants