fix clippy lints #167
Merged
fix clippy lints #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanbox-irl
requested review from
Ralith,
kanerogers and
LPGhatguy
as code owners
Ralith
reviewed
Jun 14, 2024
Ralith
approved these changes
Jun 14, 2024
Uriopass
pushed a commit
to Uriopass/yakui
that referenced
this pull request
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various nits and whatnots that clippy yells at me about (as of MSRV).
The majority of these were replacing
use std::f32::INFINITYwith a simplerf32::INFINITY, apparently becausestd::f32::INFINITYwill be deprecated at some point? It seems all a bit vague.I don't feel strongly about any of these changes in particular, but I do like a project to have no clippy warnings, so if there's anything you'd like to revert here, just lmk and I'll swap to making clippy::allows instead