Revert bugs related to selecting dictionary keys with highest values #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 81.98% 82.06% +0.07%
==========================================
Files 77 77
Lines 10520 10519 -1
==========================================
+ Hits 8625 8632 +7
+ Misses 1895 1887 -8
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610.
The
mypytype-ignore's are due to thegetmethod potentially returningNone(even though it's not possible in this case), see https://stackoverflow.com/questions/66317557/type-hints-for-dict-when-finding-min-value.