Modularized computation of protoypes importance scores #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lization function.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
==========================================
- Coverage 84.65% 84.61% -0.05%
==========================================
Files 74 74
Lines 8722 8727 +5
==========================================
Hits 7384 7384
- Misses 1338 1343 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jklaise
suggested changes
Nov 24, 2022
alibi/prototypes/protoselect.py
Outdated
Comment on lines
580
to
582
| - ``'prototypes_indices'`` - an array of the prototypes indices. | ||
|
|
||
| - ``'prototypes_importance'`` - an array of prototypes importance. |
There was a problem hiding this comment.
I think more grammatically correct would be to call these prototype_indices and prototype_importances?
There was a problem hiding this comment.
Similar for the name of the function.
alibi/prototypes/protoselect.py
Outdated
|
|
||
| - ``'X_protos'`` - an array of raw prototypes. | ||
|
|
||
| - ``'X_protos_ft'`` - an array of preprocessed prototypes. If the ``preprocess_fn=None``, no preprocessing \ |
There was a problem hiding this comment.
Should this be None (or empty) if there is no pre-processing? Basically do we avoid duplicating the same data?
There was a problem hiding this comment.
Good point!
jklaise
reviewed
Jan 3, 2023
alibi/prototypes/protoselect.py
Outdated
| def compute_prototype_importances(summary: 'Explanation', | ||
| trainset: Tuple[np.ndarray, np.ndarray], | ||
| preprocess_fn: Optional[Callable[[np.ndarray], np.ndarray]] = None, | ||
| knn_kw: Optional[dict] = None): |
There was a problem hiding this comment.
Just noticed - missing return type.
jklaise
approved these changes
Jan 4, 2023
RobertSamoilescu
added a commit
to RobertSamoilescu/alibi
that referenced
this pull request
Jan 4, 2023
* Modularized computation of protoypes importance scores from the visualization function. * Updated .gitignore. Changed notebook kernel. * Reverted .pymon and .gitignore. * Duplicate docstrings and reverted example. * Replaced prototypes_* to prototype_*. * Avoid duplication when plotting the prototypes * Updated example notebook. * Included missing return type.
RobertSamoilescu
added a commit
to RobertSamoilescu/alibi
that referenced
this pull request
Jan 4, 2023
* Modularized computation of protoypes importance scores from the visualization function. * Updated .gitignore. Changed notebook kernel. * Reverted .pymon and .gitignore. * Duplicate docstrings and reverted example. * Replaced prototypes_* to prototype_*. * Avoid duplication when plotting the prototypes * Updated example notebook. * Included missing return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modularises the computation of prototypes importance scores from the visualisation function. This gives the option to compute the importance and use a different tool to plot the 2D representation of the prototypes.