Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default /health/status implementation for models #2899

Closed
adriangonz opened this issue Jan 29, 2021 · 1 comment
Closed

Add default /health/status implementation for models #2899

adriangonz opened this issue Jan 29, 2021 · 1 comment

Comments

@adriangonz
Copy link
Contributor

Currently, the models expose the /health/status endpoint. However, this endpoint is only active when you explicitly override the health_status method of your model class.

When that method is not overriden, the endpoint will just return a 400. It would be good to, instead, fallback to a default behaviour for /health/status similar to /health/ping (which can still be later overriden by extending the health_status method).
@adriangonz adriangonz added the triage Needs to be triaged and prioritised accordingly label Jan 29, 2021
@ukclivecox ukclivecox self-assigned this Feb 11, 2021
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Feb 11, 2021
@ukclivecox ukclivecox removed their assignment Feb 18, 2021
@nadinet
Copy link
Contributor

nadinet commented Mar 30, 2021

Fixed by: #3023

@nadinet nadinet closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adriangonz @nadinet @ukclivecox