Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seldon-core 1.8.0 helm chart CRD error #3254

Closed
boniek83 opened this issue Jun 2, 2021 · 6 comments
Closed

seldon-core 1.8.0 helm chart CRD error #3254

boniek83 opened this issue Jun 2, 2021 · 6 comments
Labels
bug triage Needs to be triaged and prioritised accordingly

Comments

@boniek83
Copy link

boniek83 commented Jun 2, 2021

Describe the bug

When
CustomResourceDefinition.apiextensions.k8s.io "seldondeployments.machinelearning.seldon.io" is invalid: metadata.annotations: Too long: must have at most 262144 bytes

To reproduce

  1. Create new argocd project or use helm template using 1.8.0 seldon chart
  2. Try to deploy resulting yamls to kubernetes

Expected behaviour

It should work.

Environment

seldon-core 1.8.0
kubernetes 1.19.8
argocd 2.0.3
helm 3.6.0

@boniek83 boniek83 added bug triage Needs to be triaged and prioritised accordingly labels Jun 2, 2021
@ellisvalentiner
Copy link
Contributor

For what it's worth, this affects the CRDs for multiple Seldon versions. We're still on 1.6 and see the same thing.

You can add an ignoreDifferences statement in your Argo CD application yaml:

  ignoreDifferences:
  - group: apiextensions.k8s.io
    kind: CustomResourceDefinition
    name: seldondeployments.machinelearning.seldon.io
    jsonPointers:
    - /spec
    - /status
    - /metadata/labels

@boniek83
Copy link
Author

boniek83 commented Jun 8, 2021

Using kubectl replace (and using similar option in ArgoCD) instead of kubectl apply works.
argoproj/argo-cd#820

@axsaucedo
Copy link
Contributor

Great - thank you @boniek83, seems this has resolved the issue but great to have a reference in case other people come into the same issue. Closing the issue for now

@anilnokia
Copy link

Hello,

I have the same issue with crd error when I deploy using argocd. Could you please elaborate how to fix this problem? I am new to this.

Thanks,

Anil

@pevers
Copy link

pevers commented Aug 25, 2022

You can let ArgoCD replace resources as a syncPolicy in the application manifest.

  syncPolicy:
    syncOptions:
      - Replace=true

@boniek83
Copy link
Author

You can let ArgoCD replace resources as a syncPolicy in the application manifest.

  syncPolicy:
    syncOptions:
      - Replace=true

Replace is a workaround at best. True solution is server side apply which will be soon supported by ArgoCD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

5 participants