Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert docstrings in serving_test_gen.py to Numpy format #472

Closed
jklaise opened this issue Mar 26, 2019 · 2 comments
Closed

Convert docstrings in serving_test_gen.py to Numpy format #472

jklaise opened this issue Mar 26, 2019 · 2 comments
Assignees
@jklaise
Labels
Python
Projects
1.0
Milestone
1.0

Comments

@jklaise
Copy link
Member

jklaise commented Mar 26, 2019

The #460 does not show up in the auto-generated docs, I think this is due to the different docstring format.
@jklaise jklaise added the Python label Mar 26, 2019
@ukclivecox ukclivecox added this to the 1.0.x milestone Aug 23, 2019
@ukclivecox ukclivecox added this to To do in 1.0 via automation Aug 23, 2019
@jklaise
Copy link
Member Author

jklaise commented Aug 27, 2019

@cliveseldon on second look, the script currently sits outside the package, so wouldn't show up in the documentation regardless. Does it make sense to make it part of the package?

@ukclivecox
Copy link
Contributor

Makes sense

@jklaise jklaise mentioned this issue Aug 27, 2019
Merged
1.0 automation moved this from To do to Done Aug 27, 2019
agrski pushed a commit that referenced this issue Dec 2, 2022
@sakoush @ukclivecox
Issue 445 scheduler model autoscale (#472)
316abe1 
* fix small typo

* do not set default min replicas

* consider model loaded on replica when filtering

* add unit test

* add more tests

* add very simple crude model scaling logic

* refactor function

* lint fixes

* lint fixes

* add test

* reorder funcs

* add smoke test

* fix func name

* add scaling down test

* refactor

* lint

* simplify test

* set defaults if min / max replicas are missing

* add range checks

* tidy up scaling range logic

* more tidy up

* add more tests

* add cooling off period

* fix lint

* add range checks for replicas

* remove unused env variables

* remove  lock

* revert REQUESTS_CA_BUNDLE (#491)

* tidy up notebook with more models for triton (#494)

* Fix Strimzi Helm values ZK indent bug + stale broker service name (#492)

* Fix strimzi helm values bug for zookeeper persistent storage

* fix kafka bootstrap location to be internal SVC

* fix log message

* add env variables to runner

* tidy up comment

* switch log to debug

* do not update k8s meta if nil

* tidy up ,model name

* fix decrement bug

Co-authored-by: cliveseldon <cc@seldon.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jklaise jklaise

Labels
Python
Projects
No open projects
1.0
  
Done
Milestone
1.0
Development

No branches or pull requests
2 participants
@ukclivecox @jklaise