Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use v1 ambassador api #491

Closed
ryandawsonuk opened this issue Apr 4, 2019 · 0 comments · Fixed by #492
Closed

use v1 ambassador api #491

ryandawsonuk opened this issue Apr 4, 2019 · 0 comments · Fixed by #492

Comments

@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented Apr 4, 2019

v0 is deprecated - emissary-ingress/emissary@87f90e8#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR13

This means checking that uses in https://github.com/SeldonIO/seldon-core/blob/master/cluster-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentOperatorImpl.java#L528 such as timeout_ms, prefix and service conform to https://www.getambassador.io/reference/mappings/ or updating to the new API

agrski pushed a commit that referenced this issue Dec 2, 2022
agrski pushed a commit that referenced this issue Dec 2, 2022
* fix small typo

* do not set default min replicas

* consider model loaded on replica when filtering

* add unit test

* add more tests

* add very simple crude model scaling logic

* refactor function

* lint fixes

* lint fixes

* add test

* reorder funcs

* add smoke test

* fix func name

* add scaling down test

* refactor

* lint

* simplify test

* set defaults if min / max replicas are missing

* add range checks

* tidy up scaling range logic

* more tidy up

* add more tests

* add cooling off period

* fix lint

* add range checks for replicas

* remove unused env variables

* remove  lock

* revert REQUESTS_CA_BUNDLE (#491)

* tidy up notebook with more models for triton (#494)

* Fix Strimzi Helm values ZK indent bug + stale broker service name (#492)

* Fix strimzi helm values bug for zookeeper persistent storage

* fix kafka bootstrap location to be internal SVC

* fix log message

* add env variables to runner

* tidy up comment

* switch log to debug

* do not update k8s meta if nil

* tidy up ,model name

* fix decrement bug

Co-authored-by: cliveseldon <cc@seldon.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant