downgrade ambassador version due to grpc reliability #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively I've found that 0.50.0 works. (But 0.51.0 does not.) |
|
Now going to run as root to resolve instead of downgrading - 976c9e6 |
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
* fix small typo * do not set default min replicas * consider model loaded on replica when filtering * add unit test * add more tests * add very simple crude model scaling logic * refactor function * lint fixes * lint fixes * add test * reorder funcs * add smoke test * fix func name * add scaling down test * refactor * lint * simplify test * set defaults if min / max replicas are missing * add range checks * tidy up scaling range logic * more tidy up * add more tests * add cooling off period * fix lint * add range checks for replicas * remove unused env variables * remove lock * revert REQUESTS_CA_BUNDLE (#491) * tidy up notebook with more models for triton (#494) * Fix Strimzi Helm values ZK indent bug + stale broker service name (#492) * Fix strimzi helm values bug for zookeeper persistent storage * fix kafka bootstrap location to be internal SVC * fix log message * add env variables to runner * tidy up comment * switch log to debug * do not update k8s meta if nil * tidy up ,model name * fix decrement bug Co-authored-by: cliveseldon <cc@seldon.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgraded ambassador in #480
But it has caused problems with grpc calls on ambassador startup, recorded in #492
There was perhaps an intermittent problem already but it is much more serious in the new ambassador version (0.52.0) than it was in 0.40.2. To get the new version working we'd have to put long retry timeouts in our tests