Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1138 update integration test script with helm 3.0 #1181

Closed
wants to merge 1 commit into from
Closed

#1138 update integration test script with helm 3.0 #1181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 3 additions & 7 deletions testing/scripts/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,10 @@ kind_build_operator:

kind_build_images: kind_build_engine kind_build_operator

install_helm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation tests fail as install_helm command is required, so either script needs to be modified or install_helm should be added

kubectl -n kube-system create sa tiller
kubectl create clusterrolebinding tiller --clusterrole cluster-admin --serviceaccount=kube-system:tiller
helm init --service-account tiller
kubectl rollout status deploy/tiller-deploy -n kube-system

install_ambassador:
helm install stable/ambassador -f ambassador_values.yaml --name ambassador --set crds.keep=false --namespace seldon --set replicaCount=1
helm repo add stable https://kubernetes-charts.storage.googleapis.com/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think the helm set up should be separate, as helm is used in other parts of the integration tests.

helm repo update
helm install ambassador stable/ambassador -f ambassador_values.yaml --set crds.keep=false --namespace seldon --set replicaCount=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now the end to end tests use the dependencies in the core-builder image, which I believe don't use helm 3.x, so this change would not only have to be done in the core-builder image, and you would have to change the image that it points towards

kubectl rollout status deployment.apps/ambassador --namespace seldon

install_cert_manager:
Expand Down