Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump isort from 5.8.0 to 5.9.0 in /python #3316

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 21, 2021

Bumps isort from 5.8.0 to 5.9.0.

Release notes

Sourced from isort's releases.

5.9.0 June 21st 2021

  • Improved CLI startup time.
  • Implemented #1697: Provisional support for PEP 582: skip __pypackages__ directories by default.
  • Implemented #1705: More intuitive handling of isort:skip_file comments on streams.
  • Implemented #1737: Support for using action comments to avoid adding imports to individual files.
  • Implemented #1750: Ability to customize output format lines.
  • Implemented #1732: Support for custom sort functions.
  • Implemented #1722: Improved behavior for running isort in atomic mode over Cython source files.
  • Fixed (PyCQA/isort#1695): added imports being added to doc string in some cases.
  • Fixed (PyCQA/isort#1714): in rare cases line continuation combined with tabs can output invalid code.
  • Fixed (PyCQA/isort#1726): isort ignores reverse_sort when force_sort_within_sections is true.
  • Fixed #1741: comments in hanging indent modes can lead to invalid code.
  • Fixed #1744: repeat noqa comments dropped when * import and non * imports exist from the same package.
  • Fixed #1721: repeat noqa comments on separate from lines with force-single-line set, sometimes get dropped.
Changelog

Sourced from isort's changelog.

5.9.0 June 21st 2021

  • Improved CLI startup time.
  • Implemented #1697: Provisional support for PEP 582: skip __pypackages__ directories by default.
  • Implemented #1705: More intuitive handling of isort:skip_file comments on streams.
  • Implemented #1737: Support for using action comments to avoid adding imports to individual files.
  • Implemented #1750: Ability to customize output format lines.
  • Implemented #1732: Support for custom sort functions.
  • Implemented #1722: Improved behavior for running isort in atomic mode over Cython source files.
  • Fixed (PyCQA/isort#1695): added imports being added to doc string in some cases.
  • Fixed (PyCQA/isort#1714): in rare cases line continuation combined with tabs can output invalid code.
  • Fixed (PyCQA/isort#1726): isort ignores reverse_sort when force_sort_within_sections is true.
  • Fixed #1741: comments in hanging indent modes can lead to invalid code.
  • Fixed #1744: repeat noqa comments dropped when * import and non * imports exist from the same package.
  • Fixed #1721: repeat noqa comments on separate from lines with force-single-line set, sometimes get dropped.

Goal Zero (Tickets related to aspirational goal of achieving 0 regressions for remaining 5.0.0 lifespan):

  • Implemented #1394: 100% branch coverage (in addition to line coverage) enforced.
  • Implemented #1751: Strict typing enforcement (turned on mypy strict mode).
Commits
  • bacec68 Bump version to 5.9.0
  • 9bf7b35 Address linting errors
  • 1705835 Speed up init time further by avoiding import of ISortCommand
  • f26ba58 Add note about improving CLI startup time
  • 9abbe88 Drastically improve isort start up speed by avoiding import of deprecated fin...
  • cd2e763 Migrate mypy from setuf.cfg -> pyproject.toml. Starting running against tests...
  • 4cb72fa Implemented #1722: Improved behavior for running isort in atomic mode over Cy...
  • eada928 Update integration testst to understand new sort_order setting
  • a1a3aff Implemented #1732: Support for custom sort functions.
  • 37dcd46 Merge pull request #1757 from anirudnits/issue/1755
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [isort](https://github.com/pycqa/isort) from 5.8.0 to 5.9.0.
- [Release notes](https://github.com/pycqa/isort/releases)
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md)
- [Commits](PyCQA/isort@5.8.0...5.9.0)

---
updated-dependencies:
- dependency-name: isort
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file Python labels Jun 21, 2021
@dependabot dependabot bot requested a review from adriangonz June 21, 2021 11:06
@seldondev
Copy link
Collaborator

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@axsaucedo
Copy link
Contributor

/test integration

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/ok-to-test

@seldondev seldondev merged commit 3eacc2d into master Jun 21, 2021
@seldondev
Copy link
Collaborator

Failed to merge this PR due to:

failed merging [3316]: [Method Not Allowed]

@dependabot dependabot bot deleted the dependabot/pip/python/isort-5.9.0 branch June 21, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file ok-to-test Python size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants