Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Install Firefox extension from dist folder #15255

Merged
merged 3 commits into from
Jul 18, 2022
Merged

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Jul 15, 2022

Explanation

  • Update Selenium Webdriver from v4.1.0 to v4.3.1, to be able to install unpacked addons at runtime in FF, which was introduced in v4.2.0
  • Updated the framework to install the extension in Firefox from the dist folder similar to chrome, rather than using the zip in the build folder.
  • Removed some code from the Snaps tests which became redundant after the above change

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa marked this pull request as ready for review July 15, 2022 11:52
@PeterYinusa PeterYinusa requested a review from a team as a code owner July 15, 2022 11:52
@PeterYinusa PeterYinusa changed the title [E2E] Install FF from dist folder [E2E] Install Firefox extension from dist folder Jul 15, 2022
@metamaskbot
Copy link
Collaborator

Builds ready [296b5b2]
Page Load Metrics (1827 ± 92 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93166115189
domContentLoaded16342338181217684
load16342361182719192
domInteractive16342338181217684

@PeterYinusa PeterYinusa merged commit 9ae909d into develop Jul 18, 2022
@PeterYinusa PeterYinusa deleted the upgrade-webdriver branch July 18, 2022 08:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants