Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] add value key to downloadFile response per w3c convention #13025

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

titusfortner
Copy link
Member

Description

Add a value key to the delete downloadFile response

Motivation and Context

Per the W3C Processing Model

Let response’s body be the UTF-8 encoded JSON serialization of a JSON Object with a key "value" set to data.

Ruby expects to see a value key from all responses, even if the data value is null

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bee29a) 56.49% compared to head (8a048fe) 56.49%.
Report is 3 commits behind head on trunk.

❗ Current head 8a048fe differs from pull request most recent head fbd5d8e. Consider uploading reports for the commit fbd5d8e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13025   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2969     2969           
  Misses       2099     2099           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you, @titusfortner!

@diemol diemol merged commit aee766c into trunk Oct 23, 2023
37 of 39 checks passed
@diemol diemol deleted the delete_value branch October 23, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants