[rb] implement remote downloads

[titusfortner]

Status

Ruby delete fails because of #13025
I rebased this PR on that fix to make sure it passes

Description

• creates a new HasFileDownloads module with #downloadable_files and #download_file
• Implemented Options#enableDownloads to allow downloading
• Only RemoteWebDriver includes this new module
• Rather than put the implementation of these methods into Remote::Bridge, I created Remote::Features similar to how we've done the browser features files
• Moved the upload implementation into that new feature file
• In order to support both browser & remote command list, a new #command_list created and Remote::Features#add_commands for Remote::Driver to use
• Had to do custom processing of se:downloadsEnabled

Motivation and Context

This implements #11657

[titusfortner]

I want to hold off on this until after we releases 4.10 to keep pace with other bindings. Wanted a proof of concept in Ruby to make it easier to do it in other languages (maybe)

[diemol]

Maybe I missed this because I am not very fluent in Ruby... But I think we should return an error when the capability se:downloadsEnabled is not present.

[titusfortner]

Won't the node do this? We're not currently doing this elsewhere in ruby code, though I guess we could...

[diemol]

I guess I was thinking of disabling the method in some way or throwing an error. People will try this with any Grid they have available because most users do not read the prerequisites. Also, it won't work with most cloud vendors for now, so trying to avoid throwing work to their customer support teams.

[titusfortner]

Makes sense. We should do the same with bidi capability, then.

Oddly, ruby used to do this with the javascript enabled capability and was the only one, and this is what prevented selenium 2 ruby tests from working with Selenium 3 grid.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11b4efe) 56.49% compared to head (3d09c14) 56.49%.
Report is 19 commits behind head on trunk.

❗ Current head 3d09c14 differs from pull request most recent head cb0abf9. Consider uploading reports for the commit cb0abf9 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #12037   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2969     2969           
  Misses       2099     2099           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[giladshanan]

@titusfortner any insight on #13307?