[Python] Clear _actions after performing action_chains #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make possible to reuse `ActionChains` object after perform for other actions wihout creating a new object. case: ``` ac = ActionChains(driver) ac.move_to_element(some_element).click().perform() # ac._actions contains moving and clicking ac.send_keys(some_keys).perform() # ac._actions contains moving, clicking and sending keys, but I expect, that it contain only sending keys action. ``` Another solution is to add a new method `clear` witch will be clear self._actions list.
|
Unfortunately what we have is by design so that people can reuse actions if they want. Clearing an action after use means that people will always have to recreate things which is far from ideal Thanks for the patch though. |
|
Ok. I get it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make possible to reuse
ActionChainsobject after perform for other actions wihout creating a new object.case:
In general, it will break a backward compatibility.
Another solution is to add a new method
clearwitch will be clearself._actionslist.CLA signed as Alexander Bayandin