Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Kotlin tests on CI #1111

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Run Kotlin tests on CI #1111

merged 2 commits into from
Aug 9, 2022

Conversation

bonigarcia
Copy link
Member

Description

This PR allows running the Kotlin tests on CI. For that, this commit does the following:

  • Change workflow setup to run tests
  • Fix some tests (e.g. due to driver not available)
  • Fix doc according to the changes in the tests (e.g. referred lines)

Motivation and Context

This PR is a continuation of #1081 (Java) and #1110 (Python). The final objective is to execute all test examples in CI.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@bonigarcia bonigarcia force-pushed the run_kotlin_tests branch 2 times, most recently from 08f4807 to dd00263 Compare August 9, 2022 11:22
@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 3002c2f
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62f240390cc4850008554b0e
😎 Deploy Preview https://deploy-preview-1111--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for jovial-austin-42fe02 failed.

Name Link
🔨 Latest commit e273b96
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62f2934feafe120008e7a3cb

@bonigarcia bonigarcia force-pushed the run_kotlin_tests branch 4 times, most recently from 6e32c14 to 23dc2a5 Compare August 9, 2022 13:31
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

@diemol diemol merged commit cb6236a into trunk Aug 9, 2022
@diemol diemol deleted the run_kotlin_tests branch August 9, 2022 17:07
selenium-ci added a commit that referenced this pull request Aug 9, 2022
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>

[deploy site] cb6236a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants