Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct initialization of custom node in grid advanced features #1576

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Correct initialization of custom node in grid advanced features #1576

merged 1 commit into from
Feb 6, 2024

Conversation

bhecquet
Copy link
Contributor

@bhecquet bhecquet commented Feb 6, 2024

Description

This change corrects the way the DecoratedLoggingNode is initialized when creating a custom node. We provide it the node id of the wrapped node.

Motivation and Context

Current example had an issue as 2 node ids were created, and when the node registers itself to hub, it don't see it's registered (see issue #1571)

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@netlify Netlify
Copy link

netlify bot commented Feb 6, 2024 •
edited
Loading

✅ Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 4636a53
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/65c20c169e1dca0008d61283
😎 Deploy Preview https://deploy-preview-1576--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bhecquet bhecquet mentioned this pull request Feb 6, 2024
Closed
@diemol
Copy link
Member

diemol commented Feb 6, 2024

@krmahadevan, does it look good to you?

@krmahadevan
Copy link
Contributor

@diemol - The changes look good to me.

@diemol
Copy link
Member

diemol commented Feb 6, 2024

@diemol - The changes look good to me.

Thank you for reviewing, @krmahadevan!

@bhecquet @diemol
issue SeleniumHQ#1571: correct initialization of custom node
4636a53 
	modified:   customize_node.en.md
	modified:   customize_node.ja.md
	modified:   customize_node.pt-br.md
	modified:   customize_node.zh-cn.md
@diemol diemol merged commit ef7b2e3 into SeleniumHQ:trunk Feb 6, 2024
6 checks passed
@diemol diemol linked an issue Feb 6, 2024 that may be closed by this pull request
[🐛 Bug]: With custom node example, node never see it's registered #1571
Closed
selenium-ci added a commit that referenced this pull request Feb 6, 2024
@selenium-ci
Correct initialization of custom node in grid advanced features (#1576)
80fde71 
issue #1571: correct initialization of custom node
	modified:   customize_node.en.md
	modified:   customize_node.ja.md
	modified:   customize_node.pt-br.md
	modified:   customize_node.zh-cn.md

[deploy site] ef7b2e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmahadevan krmahadevan krmahadevan approved these changes

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: With custom node example, node never see it's registered
3 participants
@bhecquet @diemol @krmahadevan