Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work in iOS Safari private mode #131

Closed
JosephSilber opened this issue Dec 28, 2015 · 2 comments
Closed

Does not work in iOS Safari private mode #131

JosephSilber opened this issue Dec 28, 2015 · 2 comments
Assignees
Labels

Comments

@JosephSilber
Copy link

In Safari's private mode, you can't use localstorage. Any attempt to set an item to local storage will throw a quota exceeded limit, which breaks the whole player.

The only remedy currently is to disable it altogether by setting storage.enabled to false.

@sampotts
Copy link
Owner

Good catch. This an easy fix - need to actually store a test object in storage (in a try/catch) and check it actually stored. I'll make a fix.

@sampotts sampotts added the Bug label Dec 28, 2015
@sampotts sampotts self-assigned this Dec 28, 2015
@sampotts sampotts added this to the 1.5 milestone Jan 10, 2016
@sampotts
Copy link
Owner

Fixed in v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants