remove extra semi colon to fix webpack 5 build issue. #76
Conversation
|
@jlukic @xiaohanyu @nooitaf @levithomason , can you please have a look at this PR and help me merge it? This is a kind of blocking issue and makes users choose between webpack5 and Semantic UI. |
|
LGTM |
|
@nooitaf , thanks for having a look. Would you please give some idea how long it can take to get this PR merged? |
|
Thanks for the find and fix. I believe this file is generated in a build, possibly from the main repo. I will try to take a look at it soon. |
|
@levithomason , any updates? |
|
@jlukic @levithomason , thanks for looking into this. I see the PR got merged. When will these changes be reflected in the NPM package? |
|
I used this package with no issue before today. Unfortunately the recent merge may have cause me and a few of my colleagues to get an error related to the extra semi colon now. (We all started new projects today.) |
Same issue as discussed in Semantic-Org/Semantic-UI-CSS#75 and partially fixed in Semantic-Org/Semantic-UI-CSS#76
Same issue as discussed in Semantic-Org/Semantic-UI-CSS#75 and partially fixed in Semantic-Org/Semantic-UI-CSS#76
…fixes Semantic-Org/Semantic-UI-CSS#76 which prevents upgrade to Webpack 5.
* Use peacekeeper/Fomantic-UI-CSS@c94ff9b for Fomantic UI CSS because it fixes Semantic-Org/Semantic-UI-CSS#76 which prevents upgrade to Webpack 5. * Update Create React App to v5.0.
Related issues: Semantic-Org#7073 fomantic/Fomantic-UI-CSS#12 Semantic-Org/Semantic-UI-CSS#75 Semantic-Org/Semantic-UI-CSS#76 Semantic-Org/Semantic-UI-CSS#77 Semantic-Org/Semantic-UI-CSS#78 fomantic/Fomantic-UI-CSS#12 Semantic-Org/Semantic-UI-LESS#77 See also: https://www.npmjs.com/package/@semantic-ui-react/css-patch
#75